Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACS-6457] Migrated unshare-file e2es to playwright #3575

Merged
merged 10 commits into from
Dec 28, 2023
Merged

[ACS-6457] Migrated unshare-file e2es to playwright #3575

merged 10 commits into from
Dec 28, 2023

Conversation

kritagya09
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Protractor is deprecated and e2es for 'unshare-file.test.ts' are written in Protractor.

What is the new behaviour?
Migrated the Protractor test cases into Playwright for 'unshare-file.test.ts' file.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/ACS-6457

@kritagya09 kritagya09 force-pushed the dev-kritagya-ACS-6457 branch from d116dff to 1cc0f61 Compare December 28, 2023 05:38
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kritagya09 kritagya09 merged commit 6b18b63 into develop Dec 28, 2023
25 checks passed
@kritagya09 kritagya09 deleted the dev-kritagya-ACS-6457 branch December 28, 2023 06:24
akashrathod28 pushed a commit that referenced this pull request Dec 28, 2023
@kritagya09 @akashrathod28
[ACS-6457] Migrated unshare-file e2es to playwright (#3575)
0864377 
* [ACS-6457] Migrated unshare-file e2es to playwright

* Removed only

* [ACS-6457] Removed protractor file

* Updated timeout

* Updated timeout

* Removed clickClose method

* Addressed review comments

* Addressed review comments

* Created a separate test suit for share-actions

* Remove only
akashrathod28 added a commit that referenced this pull request Jan 2, 2024
@akashrathod28
[ACS-6535]add e2e test suite for copy-move-actions (#3576)
5bb7c21 
* add e2e test suite for copy-action

* code fix

* [ACS-6457] Migrated unshare-file e2es to playwright (#3575)

* [ACS-6457] Migrated unshare-file e2es to playwright

* Removed only

* [ACS-6457] Removed protractor file

* Updated timeout

* Updated timeout

* Removed clickClose method

* Addressed review comments

* Addressed review comments

* Created a separate test suit for share-actions

* Remove only

* rebase

* code fix

* code fix

---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swapnil-verma-gl swapnil-verma-gl swapnil-verma-gl approved these changes

@akashrathod28 akashrathod28 akashrathod28 approved these changes

@DenysVuika DenysVuika Awaiting requested review from DenysVuika

@eromano eromano Awaiting requested review from eromano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kritagya09 @akashrathod28 @swapnil-verma-gl